|
From: | Fred Kiefer |
Subject: | Re: Renaming _sub_views to _subviews and _super_view to _superview |
Date: | Tue, 17 May 2011 10:08:20 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 |
On 17.05.2011 00:01, Banlu Kemiyatorn wrote:
Hi Fred, I wasnt sure either but it looks safer to me like when there is something to do with setXXX would automatically match _xXX ivar (could that be the reason GSNibLoading.h has 2 versions of superview?). And things should always be spelled right, the code that could suggest someone to type subViews or superView and vice versa in their code simply shouldnt exist. So I wonder what is a good reason to keep it that way? Cheer, Banlu
This aren't exactly convincing arguments, still the code would look nicer with correct spelling. The main problem will be to find a point in time where to do the changes in gui and Gorm simultaneously. Greg is planing to do a Gorm release soon, but there is no gui release in sight. We should wait until after the Gorm release and apply the patch then. Hopefully there aren't too many applications that use these ivars directly.
Fred
[Prev in Thread] | Current Thread | [Next in Thread] |