Re: Renaming _sub_views to _subviews and _super_view to _superview

[Banlu Kemiyatorn]

Hi Fred,
I wasnt sure either but it looks safer to me like when there is something to do with setXXX would automatically match _xXX ivar (could that be the reason GSNibLoading.h has 2 versions of superview?). And things should always be spelled right, the code that could suggest someone to type subViews or superView and vice versa in their code simply shouldnt exist. So I wonder what is a good reason to keep it that way?
Cheer,
Banlu
--
Sent from my GNU/Linux N900

----- Original message -----
> Not that I am against this patch, I just don't see the reason why we
> should apply it. Is the main intention to get the correct spelling or is
> it about the extra character :-)
>
> On 15.05.2011 13:55, Banlu Kemiyatorn wrote:
> > Hi, I just resend this 2 patches and correct the mail subject as I
> > forgot to change it in the previous one, sorry for the dups.
> >
> > On Sun, May 8, 2011 at 9:23 PM, Banlu Kemiyatorn<address@hidden>
> > wrote:
> > > Hi, I was wondering why there are extra underscores between subview
> > > and superview Here are 2 patches to rename _sub_views to _subviews
> > > and _super_view to _superview
> > > I test a bit and loading old gorm and recreating one seem to work
> > > fine. Hope this patch will reduce global warming a bit in a long run.
> > >
> > > One thing, I simply remove NSView *_superview; in GSNibLoading.h in
> > > doubt but since I don't see it decode or encode anywhere so it should
> > > be okay?
> > >
> > > On Thu, Apr 28, 2011 at 11:56 AM, Banlu Kemiyatorn<address@hidden>
> > >  wrote:
> > >
> > > > why it's _sub_views and not _subviews?
>
>
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/gnustep-dev