Re: [Gnustep-cvs] r33234 - in /libs/gui/trunk: ChangeLog Source/GSThemeMenu.m

[Fred Kiefer]

On 02.06.2011 22:22, Gregory Casamento wrote:
> Author: gcasa
> Date: Thu Jun  2 22:22:39 2011
> New Revision: 33234
>
> URL: http://svn.gna.org/viewcvs/gnustep?rev=33234&view=rev
> Log:
> Use the NSArchiver to copy the menu since the copy method does not do a deep 
> enough copy.
>
> Modified:
>      libs/gui/trunk/ChangeLog
>      libs/gui/trunk/Source/GSThemeMenu.m

Haven't we been through that before?

There was a long mail exchange in March why this code was incorrect and 
causing trouble to German. At that point I suggested that you report 
back with a short example program showing what is broken with the 
[NSMenu -copyWithZone:] method. Instead you changed the code to use copy 
and now you changed it back and added this comment:

/*
* NOTE: The reason the copy or copyWithZone method is not used here is 
because
* it doesn't make a deep copy of the menu.  A deep copy is needed in 
order to
* allow the individual menu items to be used in multiple menus at one 
time without
* interfering with one another's state.
*/

This doesn't explain anything, nor will it ever help to resolve the 
issue, if there is any. It just breaks German's code again.

Don't you think that reopening the debate with what ever new evidence 
you came up with would be a lot more productive then doing a silent revert?