[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: migration to CGFloat for NSColor?
From: |
David Chisnall |
Subject: |
Re: migration to CGFloat for NSColor? |
Date: |
Tue, 25 Oct 2011 20:24:06 +0100 |
I think it's worth doing now. It will only break binaries on 64-bit platforms,
and there will only ever be more of those in the future...
Not sure about the DPS methods - a lot of those are the gui/back interface, and
they will need either replacing or modifying...
David
On 25 Oct 2011, at 20:00, Eric Wasylishen wrote:
> Hi,
> I started writing a patch to migrate NSColor to use CGFloat (in response to
> the bug report about -getComponents: taking a pointer to floats julian
> reported.) Of course, doing this will break any application code which uses
> that method. Do we want to do this? My feeling is, it is better to do it now
> than to postpone the change. I had to make updates in the color pickers,
> NSBitmapImageRep, and also updated the private -[NSGraphicsContext
> GSSetStroke/FillColor:] method to take CGFloat.
>
> There are also a lot of DPS/PS functions that take pointers to floats (for
> both setting colors, and font advances) - I guess those should not be
> modified, since that would break older OpenStep applications.
>
> Thoughts?
> Eric
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/gnustep-dev
-- Sent from my IBM 1620