|
From: | Eric Wasylishen |
Subject: | gui patch for review: -[NSView setBounds*:] - remove setNeedsDisplay: YES calls |
Date: | Fri, 20 Jan 2012 23:54:46 -0700 |
Hi, This patch reverts part of r32955 which I committed last april but I now see was a mistake, and I just discovered is breaking the copy-on-scroll behaviour of NSClipView - we end up always redrawing the entire visible portion of the document view right now. In r32955 I added [self setNeedsDisplay: YES] calls to -[NSView setBounds:], -setBoundsOrigin:, and -setBoundsSize:, even though these are documented explicitly as not marking the view for needing display. (With r32955 I was trying to fix a bug in TextEdit, which calls setBoundsSize: on NSClipView when you change the page zoom, and expects the view to mark itself as needing display. This is actually a bug in TextEdit - it should mark the clip view as needing redisplay itself.) -Eric |
NSViewBoundsRemoveSetNeedsDisplay.diff
Description: Binary data
[Prev in Thread] | Current Thread | [Next in Thread] |