Re: NSButtonImageSource weird code

[Fred Kiefer]

On 10.07.2013 22:08, Vincent R. wrote:
> Le 10.07.2013 21:43, Gregory Casamento a écrit :
> > Have you made the change you suggest and tested it?
> No I just LOOKED at the source code and I found it "weird".
> I am not even saying that it doesn't work, not tested anything.
> If you are not shocked by the line it means there is nothing.
> Oh I think I understand why I find it weird it's because the key is not
> yet assigned before the call
> of setObject, the setObject will assign the sources->imageName (don't
> know if it's clear ...)
> Sorry for the noise ->[]

You are correct, the code here is wrong and should actually not even 
compile. What is far worse is that this code here never gets used 
anywhere and isn't included in the GNUmakefile. There is another 
implementation of this class in GSNibLoading.h and this is the one we use.

I need to clean up this code by removing one of these implementations. 
Most likely the one with the bug :-)

Fred