Re: [gpsd-dev] [PATCH 2/3] Enable Windows version of gpxlogger

[Fred Wright]

On Fri, 24 Feb 2017, Robert Norris wrote:

> Disable daemonize option which is not available on Windows.

Here there's a choice between:

1) Offering an option that doesn't actually work (but AFAIK fails
gracefully and informatively).

2) Cluttering the code with conditionals needed solely to support
everyone's least favorite platform.

It's also worth noting that there's currently no mechanism for conditional
manpage content, so #2 also makes the usage text inconsistent with the
manpage.

On that basis, I'd be more inclined to go with #1, perhaps with a "doesn't
work on Windows" note in the manpage (if manpages actually work on
Windows).  The "gracefully and informatively" part should be verified,
though.  I did change the error from EINVAL to EPERM, which seems more
appropriate.

> Add check for signal compatibility as SIGQUIT may not be available.

I added a default definition for SIGQUIT (as well as SIGHUP), so this
should be unnecessary (but should be tested on Windows).

Thus, I think for now at least, this patch can go away altogether.

Fred Wright