[Groff] "make -k install" doesn't install everything it could

[Bruno Haible]

Hi,

When I use
  ./configure --prefix=$HOME/gnu-inst-groff/20060113
"make install" fails because it doesn't succeed to install GXditview.ad
in /usr/X11R6/lib/X11/app-defaults (due to missing permissions). This is OK.
So I use "make -k install". But that gives me a nonfunctional installation:
all the font files are not installed. From "make -k install" I'd to expect
to install everything that has been built and could be installed. Here is a
patch to fix this. It consists of two parts:
  - pass the make "-k" flag down to recursive invocations,
    (this is also useful independently because IDEs like Eclipse use
    "make -k" to collect all error messages),
  - make the device directories and the tmac directory depend on the C and C++
    program directories _except_ the X program directories.


2006-01-15  Bruno Haible  <address@hidden>

        Let "make -k install" install more files.
        * Makefile.in (MAKE_K_FLAG): New variable. Use it everywhere
        where $(MAKE) and $(MDEFINES) are used.
        (CPROGDIRS): Remove $(XPROGDIRS). Treat $(XPROGDIRS) like $(CPROGDIRS)
        everywhere.
        ($(DEVDIRS) $(XDEVDIRS) $(OTHERDEVDIRS) $(TTYDEVDIRS)): Don't depend
        on $(XPROGDIRS).
        ($(OTHERDIRS)): Likewise.

diff -r -c3 groff-20060113.orig/Makefile.in groff-20060113/Makefile.in
*** groff-20060113.orig/Makefile.in     2006-01-13 22:53:35.000000000 +0100
--- groff-20060113/Makefile.in  2006-01-15 19:16:54.000000000 +0100
***************
*** 530,535 ****
--- 530,537 ----
    "top_srcdir=$(top_srcdir)" \
    "version=$(version)"
  
+ MAKE_K_FLAG=`case "$(MAKEFLAGS)" in *k*) echo ' -k ';; esac`
+ 
  INCDIRS=src/include
  LIBDIRS=\
    src/libs/libgroff \
***************
*** 560,569 ****
    src/utils/lkbib \
    src/utils/addftinfo
  CPROGDIRS=\
!   src/utils/pfbtops \
!   $(XPROGDIRS)
  PROGDEPDIRS=arch/misc
! PROGDIRS=$(PROGDEPDIRS) $(CCPROGDIRS) $(CPROGDIRS)
  DEVDIRS=\
    font/devps \
    font/devdvi \
--- 562,570 ----
    src/utils/lkbib \
    src/utils/addftinfo
  CPROGDIRS=\
!   src/utils/pfbtops
  PROGDEPDIRS=arch/misc
! PROGDIRS=$(PROGDEPDIRS) $(CCPROGDIRS) $(CPROGDIRS) $(XPROGDIRS)
  DEVDIRS=\
    font/devps \
    font/devdvi \
***************
*** 626,636 ****
  
  
  $(TARGETS):
!       @$(ENVSETUP); $(MAKE) $(MDEFINES) do=$@ $(dodirs)
  
  dot: FORCE
        @$(ENVSETUP); \
!       $(MAKE) $(MDEFINES) srcdir=$(srcdir) VPATH=$(srcdir) \
          -f $(top_srcdir)/Makefile.comm \
          -f $(top_srcdir)/Makefile.sub $(do)
  
--- 627,637 ----
  
  
  $(TARGETS):
!       @$(ENVSETUP); $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) do=$@ $(dodirs)
  
  dot: FORCE
        @$(ENVSETUP); \
!       $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) srcdir=$(srcdir) VPATH=$(srcdir) \
          -f $(top_srcdir)/Makefile.comm \
          -f $(top_srcdir)/Makefile.sub $(do)
  
***************
*** 644,656 ****
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
        test -f Makefile.dep || touch Makefile.dep; \
!       $(MAKE) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.lib \
          -f Makefile.dep $(do)
  
! $(CPROGDIRS): FORCE $(LIBDIRS)
        @$(ENVSETUP); \
        if test $(srcdir) = .; then \
          srcdir=.; \
--- 645,657 ----
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
        test -f Makefile.dep || touch Makefile.dep; \
!       $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.lib \
          -f Makefile.dep $(do)
  
! $(CPROGDIRS) $(XPROGDIRS): FORCE $(LIBDIRS)
        @$(ENVSETUP); \
        if test $(srcdir) = .; then \
          srcdir=.; \
***************
*** 660,666 ****
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
        test -f Makefile.dep || touch Makefile.dep; \
!       $(MAKE) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.cpg \
--- 661,667 ----
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
        test -f Makefile.dep || touch Makefile.dep; \
!       $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.cpg \
***************
*** 676,688 ****
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
        test -f Makefile.dep || touch Makefile.dep; \
!       $(MAKE) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.ccpg \
          -f Makefile.dep $(do)
  
! $(DEVDIRS) $(XDEVDIRS) $(OTHERDEVDIRS) $(TTYDEVDIRS): FORCE $(PROGDIRS)
        @$(ENVSETUP); \
        if test $(srcdir) = .; then \
          srcdir=.; \
--- 677,689 ----
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
        test -f Makefile.dep || touch Makefile.dep; \
!       $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.ccpg \
          -f Makefile.dep $(do)
  
! $(DEVDIRS) $(XDEVDIRS) $(OTHERDEVDIRS) $(TTYDEVDIRS): FORCE $(PROGDEPDIRS) 
$(CCPROGDIRS) $(CPROGDIRS)
        @$(ENVSETUP); \
        if test $(srcdir) = .; then \
          srcdir=.; \
***************
*** 691,702 ****
        fi; \
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
!       $(MAKE) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.dev $(do)
  
! $(OTHERDIRS): $(PROGDIRS)
  
  $(INCDIRS) $(PROGDEPDIRS) $(OTHERDIRS): FORCE
        @$(ENVSETUP); \
--- 692,703 ----
        fi; \
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
!       $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.dev $(do)
  
! $(OTHERDIRS): $(PROGDEPDIRS) $(CCPROGDIRS) $(CPROGDIRS)
  
  $(INCDIRS) $(PROGDEPDIRS) $(OTHERDIRS): FORCE
        @$(ENVSETUP); \
***************
*** 707,713 ****
        fi; \
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
!       $(MAKE) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.man $(do)
--- 708,714 ----
        fi; \
        test -d $@ || $(mkinstalldirs) $@; \
        cd $@; \
!       $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) srcdir=$$srcdir VPATH=$$srcdir \
          -f $(top_srcdir)/Makefile.comm \
          -f $$srcdir/Makefile.sub \
          -f $(top_srcdir)/Makefile.man $(do)