Re: [groff] hyphenation issues

[G. Branden Robinson]

Getting back on topic...

At 2018-05-05T15:43:35+0200, Werner LEMBERG wrote:
[...]
> Please use `const int' – there is no single instance of `int const' in
> the groff code.
[...]
> >> I'd suggest adding
> >> 
> >>     HYPHEN_NONE = 0,
> >>     HYPHEN_DEFAULT = 1,
> >>     HYPHEN_MAX = 63 // Or whatever the local naming convention is.
> 
> Yes.
> 
> >> Then test for
> >> 
> >>     n > HYPHEN_MAX
> >>     n & HYPHEN_DEFAULT && n & ~HYPHEN_DEFAULT
> >> 
> >> in addition to the existing
[...]
> I prefer that.

Fresh patch, test case, and test case output attached.

My debugging instincts tell me to always report the value of an argument
being rejected.  For one thing, the user could have passed .hy a
register value (possibly with arithmetic manipulation), and if we screw
up the validity checks it's easier to see which cases are incorrect.

Comments?

-- 
Regards,
Branden

hyph.diff
Description: Text Data

hy.trf
Description: Text document

hy.trf.out
Description: Text document

signature.asc
Description: PGP signature