[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] missleading function name
|
From: |
Pavel Roskin |
|
Subject: |
Re: [PATCH] missleading function name |
|
Date: |
Wed, 04 Jun 2008 22:08:28 -0400 |
On Thu, 2008-06-05 at 01:30 +0200, Robert Millan wrote:
> IMHO the name of this function is highly misleading. It makes one think
> it just checks something, but it actually modifies our variables. I think
> "adjust" would fit better than "check".
But nothing can be better that a good old-fashioned connect before the
function. It looks like it does several things:
1) it makes sectors disk relative from partition relative (I guess
that's what grub-emu forgets)
2) it normalizes offset to be less than the sector size
3) it verifies that the range is inside the partition.
--
Regards,
Pavel Roskin