Re: Some concern about the journal support

[Bean]

On Sun, Jun 15, 2008 at 2:06 AM, Robert Millan <address@hidden> wrote:
> On Sun, Jun 15, 2008 at 01:32:23AM +0800, Bean wrote:
>> -/* Read LEN bytes from the block BLOCK on disk DISK into the buffer BUF,
>> -   beginning with the block POS.  Apply mappings from LOG.  The blocks
>> -   have a size of LOG2BLOCKSIZE (in log2).  */
>> -grub_err_t grub_fshelp_read (grub_disk_t disk, grub_fshelp_journal_t log,
>> -                          grub_disk_addr_t block, grub_off_t pos,
>> -                          grub_size_t len, char *buf, int log2blocksize)
>> -{
>> [...]
>> -
>> -grub_disk_addr_t
>> -grub_fshelp_map_block (grub_fshelp_journal_t log, grub_disk_addr_t block)
>> -{
>
> Why are these functions removed?  I suppose they were only useful for journal
> handling?  But they predate journal support, which is a bit confusing..

Hi,

grub_fshelp_map_block is used to map a fs block to the one in journal.
grub_fshelp_read is added a few days ago to fix a mapping issue. These
two function are only used by journal.

-- 
Bean