Re: [PATCH] Enable writing to ATA devices, fix several bugs

[Marco Gerards]

Pavel Roskin <address@hidden> writes:

> We have save_env now, so we can use the write capability.  This also
> fixes the last compiler warning in GRUB.

Great!

> Sorry, Marco, please ignore the previous message, as it didn't get to
> the list.

The more patches I get, the better ;-)

> ChangeLog:
>
>       * disk/ata.c (grub_ata_pio_write): Check status before writing,
>       like we do in grub_ata_pio_read().
>
>       (grub_ata_readwrite): Always write individual sectors.  Fix the
>       sector count for the remainder.

Why?

>       (grub_ata_write): Enable writing to ATA devices.  Correctly
>       report error for ATAPI devices.


Great!  Did you test this?

If you can fix Roberts comment, it would be great!  Can you commit it
afterwards?

--
Marco