[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pc & gpt partmap iterators don't abort when their hook reque
|
From: |
Marco Gerards |
|
Subject: |
Re: [PATCH] pc & gpt partmap iterators don't abort when their hook requests it |
|
Date: |
Thu, 03 Jul 2008 20:31:05 +0200 |
|
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Robert Millan <address@hidden> writes:
> On Tue, Jul 01, 2008 at 03:25:32PM +0200, Robert Millan wrote:
>>
>> See ChangeLog for description. I'd really like to receive some review on
>> this one, since the code it touches is so fragile (although I tested it on a
>> typical setup and it works).
>
> Tough luck. Inmediately after this I noticed it breaks grub-setup (I tested
> it
> by loading core.img directly).
>
> I found a few other callers that relied on the buggy behaviour. Here's a new
> patch.
Thanks for fixing this. I had a quick look and it looks sane at first
sight. Did you have a look at the other modules as well?
--
Marco