[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] skip over invalid BSD partitions
From: |
Felix Zielcke |
Subject: |
Re: [PATCH] skip over invalid BSD partitions |
Date: |
Tue, 05 Aug 2008 15:19:06 +0200 |
Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards:
> Felix Zielcke <address@hidden> writes:
>
> > 2008-08-05 Felix Zielcke <address@hidden>
> >
> > * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid
> > BSD
> > magic or if there's no space left, use grub_dprintf to issue a warning.
>
> Looks fine.
Hurray.
> > + {
> > + grub_dprintf ("partition",
> > + "invalid disk label magic 0x%x on partition
> > %d\n"
> > + label.magic, p.index);
> > + continue;
> > + }
>
> Isn't a comma missing after the second string? I am surprised that
> this compiles. Or am I missing something?
>
You're right, shame on me I notice to missing spaces but not a missing
comma.
Attached.
skip_invalid_bsd_parts.diff
Description: Text Data
- Re: [PATCH] skip over invalid BSD partitions, Marco Gerards, 2008/08/01
- Re: [PATCH] skip over invalid BSD partitions, Felix Zielcke, 2008/08/01
- Re: [PATCH] skip over invalid BSD partitions, Robert Millan, 2008/08/01
- Re: [PATCH] skip over invalid BSD partitions, Marco Gerards, 2008/08/05
- Re: [PATCH] skip over invalid BSD partitions, Felix Zielcke, 2008/08/05
- Re: [PATCH] skip over invalid BSD partitions, Felix Zielcke, 2008/08/05
- Re: [PATCH] skip over invalid BSD partitions, Marco Gerards, 2008/08/05
- Re: [PATCH] skip over invalid BSD partitions, Felix Zielcke, 2008/08/05
- Re: [PATCH] skip over invalid BSD partitions,
Felix Zielcke <=
- Re: [PATCH] skip over invalid BSD partitions, Marco Gerards, 2008/08/05