Re: [PATCH] skip over invalid BSD partitions

[Marco Gerards]

Felix Zielcke <address@hidden> writes:

> Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards:
>> Felix Zielcke <address@hidden> writes:
>> 
>> > 2008-08-05  Felix Zielcke  <address@hidden>
>> >
>> >    * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid 
>> > BSD
>> >    magic or if there's no space left, use grub_dprintf to issue a warning.
>> 
>> Looks fine.
> Hurray.
>
>> > +              {
>> > +                grub_dprintf ("partition",
>> > +                              "invalid disk label magic 0x%x on partition 
>> > %d\n"
>> > +                              label.magic, p.index);
>> > +                continue;
>> > +              }
>> 
>> Isn't a comma missing after the second string?  I am surprised that
>> this compiles.  Or am I missing something?
>> 
> You're right, shame on me I notice to missing spaces but not a missing
> comma.
> Attached.

Seems fine to me :-)

--
Marco