[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Replace magic numbers by constants
|
From: |
Robert Millan |
|
Subject: |
Re: [PATCH] Replace magic numbers by constants |
|
Date: |
Sun, 17 Aug 2008 17:37:19 +0200 |
|
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Sun, Aug 17, 2008 at 04:29:16PM +0200, Carles Pina i Estany wrote:
> 2008-08-17 Carles Pina i Estany <address@hidden>
>
> * menu/normal.c (run_menu): Change magic numbers by constants
> (16 by GRUB_TERM_UP and 14 by GRUB_TERM_DOWN)
When reading the subject I thought it was the other way around. Would
something like:
"replace hardcoded numbers with macros"
or
"macroify numbers"
etc, make it more clear?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."