[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Replace magic numbers by constants
From: |
Carles Pina i Estany |
Subject: |
Re: [PATCH] Replace magic numbers by constants |
Date: |
Wed, 20 Aug 2008 11:26:25 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hola,
On Aug/17/2008, Carles Pina i Estany wrote:
> > When reading the subject I thought it was the other way around. Would
> > something like:
> >
> > "replace hardcoded numbers with macros"
> >
> > or
> >
> > "macroify numbers"
>
> Ok:
>
> --------
> 2008-08-17 Carles Pina i Estany <address@hidden>
>
> * menu/normal.c (run_menu): Replace hardcoded numbers with macros
> (16 for GRUB_TERM_UP and 14 for GRUB_TERM_DOWN)
> --------
>
> > etc, make it more clear?
>
> An English note: In my previous mail I've confused "change ... by"
> with "change ... for" :-)
any other change is needed? (patch or changelog) or patch is not needed
and then i will forget about it :-)
--
Carles Pina i Estany GPG id: 0x17756391
http://pinux.info