Re: [PATCH] Install to LVM PVs

[Dryden Personalis]

Andrei Borzenkov schreef op 09-05-2016 8:07:

> No, I do not want to change it at all. It should remain as is and 
> always
> probe for FS so that test below actually works

But its output makes no sense, there cannot be a filesystem in a PV. It 
could check for existence of VG AND LV AND filesystem but does it do 
that right now?

Installing Grub is generally a non-destructive operation, apart from 
overwriting the boot sector.

Anyway my foot is hurting and I can't sit behind the computer, I will 
just show the code at some point so to discuss that alright.

> > I take it you mean:
> >
> > if (!is_lvm && (ctx.multiple_partmaps || (ctx.dest_partmap && fs) ||
> > (is_ldm && fs)))
>
> I mean
>
> if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || ((is_ldm ||
> is_lvm) && fs))

Yes, I realized. Sorry.