Re: [PATCH v3 5/8] verifiers: Rename verify module to pgp module

[Ross Philipson]

On 10/03/2018 05:36 AM, Daniel Kiper wrote:
> Just for clarity. No functional change.
> 
> Signed-off-by: Daniel Kiper <address@hidden>
> ---
>  grub-core/Makefile.core.def |    4 +-
>  grub-core/commands/pgp.c    | 1018 
> +++++++++++++++++++++++++++++++++++++++++++
>  grub-core/commands/verify.c | 1018 
> -------------------------------------------
>  3 files changed, 1020 insertions(+), 1020 deletions(-)
>  create mode 100644 grub-core/commands/pgp.c
>  delete mode 100644 grub-core/commands/verify.c
> 
> diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
> index dfcc95d..3008b58 100644
> --- a/grub-core/Makefile.core.def
> +++ b/grub-core/Makefile.core.def
> @@ -888,8 +888,8 @@ module = {
>  };
>  
>  module = {
> -  name = verify;
> -  common = commands/verify.c;
> +  name = pgp;
> +  common = commands/pgp.c;
>    cflags = '$(CFLAGS_POSIX)';
>    cppflags = '-I$(srcdir)/lib/posix_wrap';
>  };
> diff --git a/grub-core/commands/pgp.c b/grub-core/commands/pgp.c
> new file mode 100644
> index 0000000..d5d7c0f
> --- /dev/null
> +++ b/grub-core/commands/pgp.c
> @@ -0,0 +1,1018 @@

[snip]

> diff --git a/grub-core/commands/verify.c b/grub-core/commands/verify.c
> deleted file mode 100644
> index d5d7c0f..0000000
> --- a/grub-core/commands/verify.c
> +++ /dev/null
> @@ -1,1018 +0,0 @@

[snip]

Scanning through this in a split view, the new file looks exactly the
same as the old one. Shouldn't this just be a git mv (a rename commit)
instead of deleting the old file and adding a new one?