Re: [PATCH v3 1/8] verifiers: File type for fine-grained signature-verification controlling

[Daniel Kiper]

On Wed, Oct 03, 2018 at 01:33:26PM -0400, Ross Philipson wrote:
> On 10/03/2018 05:36 AM, Daniel Kiper wrote:

[...]

> >  grub_file_t
> > -grub_file_open (const char *name)
> > +grub_file_open (const char *name, enum grub_file_type type)
> >  {
> >    grub_device_t device = 0;
> >    grub_file_t file = 0, last_file = 0;
> > @@ -114,18 +113,20 @@ grub_file_open (const char *name)
> >    file->name = grub_strdup (name);
> >    grub_errno = GRUB_ERR_NONE;
> >
> > -  for (filter = 0; file && filter < ARRAY_SIZE (grub_file_filters_enabled);
> > +  for (filter = 0; file && filter < ARRAY_SIZE (grub_file_filters);
> >         filter++)
> > -    if (grub_file_filters_enabled[filter])
> > +    if (grub_file_filters[filter])
> >        {
> >     last_file = file;
> > -   file = grub_file_filters_enabled[filter] (file, name);
> > +   file = grub_file_filters[filter] (file, type);
> > +   if (file && file != last_file)
> > +     {
> > +       file->name = grub_strdup (name);
> > +       grub_errno = GRUB_ERR_NONE;
> > +     }
>
> This doesn't seem like it is related to adding file type information.
> Was the setting of the name just something that was already missing/broken?

Looks strange... I will take closer look at Vladimir patches
and try to remove the clutter...

Daniel