[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_di
From: |
Lee Jones |
Subject: |
Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression |
Date: |
Tue, 20 Nov 2018 12:26:50 +0000 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Tue, 20 Nov 2018, Julien Grall wrote:
> Hi,
>
> On 20/11/2018 11:22, Lee Jones wrote:
> > On Tue, 20 Nov 2018, Julien Grall wrote:
> > > On 20/11/2018 10:46, Lee Jones wrote:
> > > > From: Lee Jones <address@hidden>
> > > >
> > > > arm64/xen: Fix implicit declaration of function
> > > > ‘grub_file_filter_disable_compression
> > >
> > > This patch seems to drop support for --nounzip. Can you explain why?
> >
> > It only seemed to serve the invocation of
> > grub_file_filter_disable_compression()
> > which was removed in this patch.
>
> But --nounzip will not work as expected after this patch. Looking at GRUB,
> it seems the call to that function was replaced by passing
> GRUB_FILE_TYPE_NO_DECOMPRESSION to grub_file_open.
Ah yes, I see. Please bear with me.
I need to split this patch too.
> Is there any reason to not use it for Arm?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
- [PATCH v2] arm64/xen: Fix too few arguments to function ‘grub_file_open’, (continued)
- arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’, Lee Jones, 2018/11/20
- Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’, Julien Grall, 2018/11/20
- Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’, Daniel Kiper, 2018/11/21
- Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’, Lee Jones, 2018/11/22
- arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Lee Jones, 2018/11/20
- Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Julien Grall, 2018/11/20
- Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Lee Jones, 2018/11/20
- Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Julien Grall, 2018/11/20
- Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression,
Lee Jones <=
- [PATCH v2] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Lee Jones, 2018/11/20
- [PATCH v3 (part 1)] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Lee Jones, 2018/11/20
- Re: [PATCH v3 (part 1)] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Daniel Kiper, 2018/11/21
- [PATCH v3 (part 2)] generic/blocklist: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Lee Jones, 2018/11/20
- Re: [PATCH v3 (part 2)] generic/blocklist: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Vladimir 'phcoder' Serbinenko, 2018/11/20
- Re: [PATCH v3 (part 2)] generic/blocklist: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Daniel Kiper, 2018/11/21
- arm64/xen: Remove duplicate check for arguments, Lee Jones, 2018/11/20
- Re: arm64/xen: Remove duplicate check for arguments, Vladimir 'phcoder' Serbinenko, 2018/11/20
Re: [PATCH 0/5] Fix non-x86 builds after verifiers framework merged, Daniel Kiper, 2018/11/16