[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2] arm64/xen: Fix implicit declaration of function ‘grub_file_fi
From: |
Lee Jones |
Subject: |
[PATCH v2] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression |
Date: |
Tue, 20 Nov 2018 11:38:19 +0000 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
From: Lee Jones <address@hidden>
arm64/xen: Fix implicit declaration of function
‘grub_file_filter_disable_compression
Without this fix, building xen_boot.c omits:
loader/arm64/xen_boot.c:433:5: error: implicit declaration of function
‘grub_file_filter_disable_compression’; did you mean
‘grub_file_filter_unregister’? [-Werror=implicit-function-declaration]
grub_file_filter_disable_compression ();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
grub_file_filter_unregister
loader/arm64/xen_boot.c:433:5: error: nested extern declaration of
‘grub_file_filter_disable_compression’ [-Werror=nested-externs]
Signed-off-by: Lee Jones <address@hidden>
diff --git a/grub-core/loader/arm64/xen_boot.c
b/grub-core/loader/arm64/xen_boot.c
index 33a855df4..117293fb9 100644
--- a/grub-core/loader/arm64/xen_boot.c
+++ b/grub-core/loader/arm64/xen_boot.c
@@ -391,7 +391,6 @@ grub_cmd_xen_module (grub_command_t cmd
__attribute__((unused)),
struct xen_boot_binary *module = NULL;
grub_file_t file = 0;
- int nounzip = 0;
if (!argc)
{
@@ -403,7 +402,6 @@ grub_cmd_xen_module (grub_command_t cmd
__attribute__((unused)),
{
argv++;
argc--;
- nounzip = 1;
}
if (!argc)
@@ -429,8 +427,6 @@ grub_cmd_xen_module (grub_command_t cmd
__attribute__((unused)),
grub_dprintf ("xen_loader", "Init module and node info\n");
- if (nounzip)
- grub_file_filter_disable_compression ();
file = grub_file_open (argv[0]);
if (!file)
goto fail;
diff --git a/grub-core/osdep/generic/blocklist.c
b/grub-core/osdep/generic/blocklist.c
index 74024fd06..63e0aed35 100644
--- a/grub-core/osdep/generic/blocklist.c
+++ b/grub-core/osdep/generic/blocklist.c
@@ -59,7 +59,6 @@ grub_install_get_blocklist (grub_device_t root_dev,
grub_disk_cache_invalidate_all ();
- grub_file_filter_disable_compression ();
file = grub_file_open (core_path_dev);
if (file)
{
@@ -117,7 +116,6 @@ grub_install_get_blocklist (grub_device_t root_dev,
grub_file_t file;
/* Now read the core image to determine where the sectors are. */
- grub_file_filter_disable_compression ();
file = grub_file_open (core_path_dev);
if (! file)
grub_util_error ("%s", grub_errmsg);
- Re: [PATCH v2] arm64/xen: Fix too few arguments to function ‘grub_file_open’, (continued)
- Re: [PATCH v2] arm64/xen: Fix too few arguments to function ‘grub_file_open’, Daniel Kiper, 2018/11/21
- arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’, Lee Jones, 2018/11/20
- Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’, Julien Grall, 2018/11/20
- Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’, Daniel Kiper, 2018/11/21
- Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’, Lee Jones, 2018/11/22
- arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Lee Jones, 2018/11/20
- Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Julien Grall, 2018/11/20
- Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Lee Jones, 2018/11/20
- Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Julien Grall, 2018/11/20
- Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression, Lee Jones, 2018/11/20
- [PATCH v2] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression,
Lee Jones <=
- [PATCH v3 (part 1)] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Lee Jones, 2018/11/20
- Re: [PATCH v3 (part 1)] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Daniel Kiper, 2018/11/21
- [PATCH v3 (part 2)] generic/blocklist: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Lee Jones, 2018/11/20
- Re: [PATCH v3 (part 2)] generic/blocklist: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Vladimir 'phcoder' Serbinenko, 2018/11/20
- Re: [PATCH v3 (part 2)] generic/blocklist: Fix implicit declaration of function ‘grub_file_filter_disable_compression', Daniel Kiper, 2018/11/21
- arm64/xen: Remove duplicate check for arguments, Lee Jones, 2018/11/20
- Re: arm64/xen: Remove duplicate check for arguments, Vladimir 'phcoder' Serbinenko, 2018/11/20
Re: [PATCH 0/5] Fix non-x86 builds after verifiers framework merged, Daniel Kiper, 2018/11/16