[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/3] grub: add grub variable extend functionality
From: |
Prarit Bhargava |
Subject: |
[PATCH v2 0/3] grub: add grub variable extend functionality |
Date: |
Wed, 16 Jan 2019 13:34:40 -0500 |
This patchset allows a user to update an existing grub variable on the
commandline.
v2:
- Split into 3 patches.
- fix "=value" bug. An additional consequence of this is that the
value pointer p in set_variable() cannot underflow.
- make grub_envblk_iterate return an int and fix return values.
- add "+=" functionality
- Changes suggested by David Kiper: Change name to grub_envblk_extend(),
capitalize comments, use standard GRUB error enum, change goto from
"out" to "err", drop cast in grub_strlen() call, use grub_snprintf()
instead of strcpy & memcpy.
- Instead of parsing envblk separately, use grub_envblk_iterate()
- use a case statement in set_variable() error handling, and add a comment
about deleting the "=" sign.
Signed-off-by: Prarit Bhargava <address@hidden>
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Cc: Daniel Kiper <address@hidden>
Prarit Bhargava (3):
grub-editenv: Verify the variable size
grub: Make grub_envblk_iterate() return an int
grub: add extend variable functionality
grub-core/commands/loadenv.c | 6 +--
grub-core/lib/envblk.c | 17 ++++---
include/grub/err.h | 4 +-
include/grub/lib/envblk.h | 6 +--
util/grub-editenv.c | 86 ++++++++++++++++++++++++++++++++++--
5 files changed, 100 insertions(+), 19 deletions(-)
--
2.17.2
- [PATCH v2 0/3] grub: add grub variable extend functionality,
Prarit Bhargava <=