[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/3] grub-editenv: Verify the variable size
From: |
Prarit Bhargava |
Subject: |
[PATCH v2 1/3] grub-editenv: Verify the variable size |
Date: |
Wed, 16 Jan 2019 13:34:41 -0500 |
It is possible to execute 'grub-editenv - set ="some data"',
which results in an unremoveable entry
="some data"
Verify the variable has a size before setting a value.
Signed-off-by: Prarit Bhargava <address@hidden>
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Cc: Daniel Kiper <address@hidden>
---
util/grub-editenv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/util/grub-editenv.c b/util/grub-editenv.c
index 118e89fe57fe..0b6c69b9688c 100644
--- a/util/grub-editenv.c
+++ b/util/grub-editenv.c
@@ -217,6 +217,9 @@ set_variables (const char *name, int argc, char *argv[])
*(p++) = 0;
+ if (! grub_strlen(argv[0]))
+ grub_util_error (_("No parameter specified"));
+
if (! grub_envblk_set (envblk, argv[0], p))
grub_util_error ("%s", _("environment block too small"));
--
2.17.2