Re: [PATCH] uboot: Add the missing disk write operation support

[Daniel Kiper]

On Wed, Jan 16, 2019 at 10:56:56PM +0100, Daniel Kiper wrote:
> On Tue, Jan 15, 2019 at 04:59:56PM +0200, Cristian Ciocaltea wrote:
> > uboot_disk_write() is currently lacking the write support
> > to storage devices because, historically, those devices did not
> > implement block_write() in U-Boot.
> >
> > The solution has been tested using a patched U-Boot loading
> > and booting GRUB in a QEMU vexpress-a9 environment.
> > The disk write operations were triggered with GRUB's save_env
> > command.
> >
> > Signed-off-by: Cristian Ciocaltea <address@hidden>
>
> Reviewed-by: Daniel Kiper <address@hidden>
>
> If there are no objections I will apply this patch in a week or so.

Sorry but at least ARM build breaks in the following way:

disk/uboot/ubootdisk.c: In function ‘uboot_disk_write’:
disk/uboot/ubootdisk.c:275:42: error: passing argument 2 of 
‘grub_uboot_dev_write’ discards ‘const’ qualifier from pointer target type 
[-Werror=discarded-qualifiers]
   retval = grub_uboot_dev_write (d->dev, buf, numblocks, offset);
                                          ^~~
In file included from ../include/grub/uboot/disk.h:24:0,
                 from disk/uboot/ubootdisk.c:27:
../include/grub/uboot/uboot.h:75:5: note: expected ‘void *’ but argument is of 
type ‘const char *’
 int grub_uboot_dev_write (struct device_info *dev, void *buf, grub_size_t 
blocks,
     ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Hence, I am waiting for fixed version from you.

Daniel