Re: [PATCH 3/3] Add tests for cmdline module

[Konrad Rzeszutek Wilk]

On Fri, Jun 12, 2020 at 05:14:23PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> -- 
> Regards
> Vladimir 'phcoder' Serbinenko


>From 69e11c5a68e75c9f48953e320cddbdf3e7f9eb46 Mon Sep 17 00:00:00 2001
>From: Vladimir Serbinenko <phcoder@gmail.com>
>Date: Fri, 12 Jun 2020 17:09:44 +0200
>Subject: [PATCH 3/3] Add tests for cmdline module
>
>Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
>---
> grub-core/Makefile.core.def           | 12 +++++
> grub-core/tests/loader_cmdline_test.c | 69 +++++++++++++++++++++++++++
> 2 files changed, 81 insertions(+)
> create mode 100644 grub-core/tests/loader_cmdline_test.c
>
>diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
>index 166b444c7..5038e03be 100644
>--- a/grub-core/Makefile.core.def
>+++ b/grub-core/Makefile.core.def
>@@ -1823,6 +1823,13 @@ module = {
>   enable = noemu;
> };
> 
>+/* Special case for emu so we always have cmdline available for the tests.  */
>+module = {
>+  name = cmdline_lib;
>+  common = lib/cmdline.c;
>+  enable = emu;
>+};
>+
> module = {
>   name = fdt;
>   efi = loader/efi/fdt.c;
>@@ -2119,6 +2126,11 @@ module = {
>   common = tests/strtoull_test.c;
> };
> 
>+module = {
>+  name = loader_cmdline_test;
>+  common = tests/loader_cmdline_test.c;
>+};
>+
> module = {
>   name = setjmp_test;
>   common = tests/setjmp_test.c;
>diff --git a/grub-core/tests/loader_cmdline_test.c 
>b/grub-core/tests/loader_cmdline_test.c
>new file mode 100644
>index 000000000..c3f6bcebe
>--- /dev/null
>+++ b/grub-core/tests/loader_cmdline_test.c
>@@ -0,0 +1,69 @@
>+/*
>+ *  GRUB  --  GRand Unified Bootloader
>+ *  Copyright (C) 2013  Free Software Foundation, Inc.

2013?