[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/6] grub-fstest: Fix resource leaks in cmd_cmp()
From: |
Darren Kenny |
Subject: |
[PATCH 3/6] grub-fstest: Fix resource leaks in cmd_cmp() |
Date: |
Tue, 26 Oct 2021 15:02:37 +0000 |
In the function cmd_cmp() within the while loop, srcnew and destnew are
being allocated but are never freed either before leaving scope or in
the recursive calls being made to cmd_cmp().
Fixes: CID 314032
Fixes: CID 314045
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
---
util/grub-fstest.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/grub-fstest.c b/util/grub-fstest.c
index 838656420098..da0751222f88 100644
--- a/util/grub-fstest.c
+++ b/util/grub-fstest.c
@@ -299,10 +299,15 @@ cmd_cmp (char *src, char *dest)
*ptr++ = '/';
strcpy (ptr, entry->d_name);
- if (grub_util_is_special_file (destnew))
+ if (grub_util_is_special_file (destnew)) {
+ free(srcnew);
+ free(destnew);
continue;
+ }
cmd_cmp (srcnew, destnew);
+ free(srcnew);
+ free(destnew);
}
grub_util_fd_closedir (dir);
return;
--
2.27.0
- [PATCH 0/6] Fix some Coverity low-hanging bugs, Darren Kenny, 2021/10/26
- [PATCH 6/6] gzio: Fix possible use of uninitialized variable in huft_build(), Darren Kenny, 2021/10/26
- [PATCH 3/6] grub-fstest: Fix resource leaks in cmd_cmp(),
Darren Kenny <=
- [PATCH 4/6] grub-mkfont: Fix memory leak in write_font_pf2(), Darren Kenny, 2021/10/26
- [PATCH 2/6] grub-mkrescue: Fix memory leak in write_part(), Darren Kenny, 2021/10/26
- [PATCH 1/6] grub-install-common: Fix memory leak in copy_all(), Darren Kenny, 2021/10/26
- [PATCH 5/6] zfs: Fix possible insecure use of chunk size in zap_leaf_array_get(), Darren Kenny, 2021/10/26
- Re: [PATCH 0/6] Fix some Coverity low-hanging bugs, Daniel Kiper, 2021/10/28