[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] Fix some Coverity low-hanging bugs
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 0/6] Fix some Coverity low-hanging bugs |
Date: |
Thu, 28 Oct 2021 23:29:16 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Oct 26, 2021 at 03:02:34PM +0000, Darren Kenny wrote:
> Coverity has flagged a number of small issues that should be fixed to help in
> cleaning up the code - these here are primarily memory leaks or uninitialized
> variables.
>
> In theory leaked memory is significant, but for short-lived processes it is
> minor.
>
> Similarly for unitinialized variables - some compilers will do the right thing
> and zero out the value allocated on the stack, but some won't. So it is better
> to be sure of the content that leave it open for possible misuse.
>
> Darren Kenny (6):
> grub-install-common: Fix memory leak in copy_all()
> grub-mkrescue: Fix memory leak in write_part()
> grub-fstest: Fix resource leaks in cmd_cmp()
> grub-mkfont: Fix memory leak in write_font_pf2()
> zfs: Fix possible insecure use of chunk size in zap_leaf_array_get()
> gzio: Fix possible use of uninitialized variable in huft_build()
For all the patches: Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Thank you for fixing these issues.
Daniel
- [PATCH 0/6] Fix some Coverity low-hanging bugs, Darren Kenny, 2021/10/26
- [PATCH 6/6] gzio: Fix possible use of uninitialized variable in huft_build(), Darren Kenny, 2021/10/26
- [PATCH 3/6] grub-fstest: Fix resource leaks in cmd_cmp(), Darren Kenny, 2021/10/26
- [PATCH 4/6] grub-mkfont: Fix memory leak in write_font_pf2(), Darren Kenny, 2021/10/26
- [PATCH 2/6] grub-mkrescue: Fix memory leak in write_part(), Darren Kenny, 2021/10/26
- [PATCH 1/6] grub-install-common: Fix memory leak in copy_all(), Darren Kenny, 2021/10/26
- [PATCH 5/6] zfs: Fix possible insecure use of chunk size in zap_leaf_array_get(), Darren Kenny, 2021/10/26
- Re: [PATCH 0/6] Fix some Coverity low-hanging bugs,
Daniel Kiper <=