grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 7/8] loader/powerpc/ieee1275: Use new allocation function for ker


From: Stefan Berger
Subject: [PATCH 7/8] loader/powerpc/ieee1275: Use new allocation function for kernel and initrd
Date: Fri, 27 Oct 2023 10:14:10 -0400

Use the new memory allocation function that honors restrictions
on which memory grub can actually use and which regions it must
avoid.

Signed-off-by: stefan Berger <stefanb@linux.ibm.com>
Cc: Hari Bathini <hbathini@linux.ibm.com>
Cc: Pavithra Prakash <pavrampu@in.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Carolyn Scherrer <cpscherr@us.ibm.com>
Cc: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Cc: Sourabh Jain <sourabhjain@linux.ibm.com>
---
 grub-core/loader/powerpc/ieee1275/linux.c | 24 ++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/grub-core/loader/powerpc/ieee1275/linux.c 
b/grub-core/loader/powerpc/ieee1275/linux.c
index e6d071508..e5952a164 100644
--- a/grub-core/loader/powerpc/ieee1275/linux.c
+++ b/grub-core/loader/powerpc/ieee1275/linux.c
@@ -30,6 +30,7 @@
 #include <grub/lib/cmdline.h>
 #include <grub/cache.h>
 #include <grub/linux.h>
+#include <grub/powerpc/ieee1275/alloc.h>
 
 GRUB_MOD_LICENSE ("GPLv3+");
 
@@ -116,6 +117,22 @@ grub_linux_claimmap_iterate (grub_addr_t target, 
grub_size_t size,
   return ctx.found_addr;
 }
 
+static grub_addr_t
+grub_linux_claimmap_iterate_restricted (grub_size_t size, grub_size_t align)
+{
+  struct regions_claim_request rcr = {
+    .flags = GRUB_MM_ADD_REGION_CONSECUTIVE,
+    .total = size,
+    .init_region = false,
+    .addr = (grub_uint64_t) -1,
+    .align = align,
+  };
+
+  grub_machine_mmap_iterate (alloc_mem_restricted, &rcr);
+
+  return rcr.addr;
+}
+
 static grub_err_t
 grub_linux_boot (void)
 {
@@ -230,7 +247,7 @@ grub_linux_load64 (grub_elf_t elf, const char *filename)
   /* On some systems, firmware occupies the memory we're trying to use.
    * Happily, Linux can be loaded anywhere (it relocates itself).  Iterate
    * until we find an open area.  */
-  seg_addr = grub_linux_claimmap_iterate (base_addr & ~ELF64_LOADMASK, 
linux_size, align);
+  seg_addr = grub_linux_claimmap_iterate_restricted (linux_size, align);
   if (seg_addr == (grub_addr_t) -1)
     return grub_error (GRUB_ERR_OUT_OF_MEMORY, "couldn't claim memory");
 
@@ -318,7 +335,6 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ 
((unused)),
                 int argc, char *argv[])
 {
   grub_size_t size = 0;
-  grub_addr_t first_addr;
   grub_addr_t addr;
   struct grub_linux_initrd_context initrd_ctx = { 0, 0, 0 };
 
@@ -339,11 +355,9 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ 
((unused)),
 
   size = grub_get_initrd_size (&initrd_ctx);
 
-  first_addr = linux_addr + linux_size;
-
   /* Attempt to claim at a series of addresses until successful in
      the same way that grub_rescue_cmd_linux does.  */
-  addr = grub_linux_claimmap_iterate (first_addr, size, 0x100000);
+  addr = grub_linux_claimmap_iterate_restricted (size, 0x100000);
   if (addr == (grub_addr_t) -1)
      goto fail;
 
-- 
2.25.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]