[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/8] ppc64: Restrict memory allocations for kernel and initrd
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 0/8] ppc64: Restrict memory allocations for kernel and initrd |
Date: |
Tue, 31 Oct 2023 16:20:38 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, Oct 27, 2023 at 10:14:03AM -0400, Stefan Berger wrote:
> This series of patches converts the memory allocator for kernel and initrd
> to use the ppc64 regions_claim memory allocator that takes into account
> memory regions that are not allowed to be used, such as the gap between
> 640MB and 768MB as well as memory regions beyond an upper address in case
> an fadump is present. Otherwise those two could be loaded into those
> forbidden memory regions and either cause a crash or corruption of the
> fadump.
>
> I adjusted the kernel and initrd load in loader/powerpc/ieee1275 to use the
> new memory allocator. I am not aware of which other platforms besides
> PowerVM and PowerKVM, if any, may be using this code and so I did not
> touch the functions loading 32 bit kernels, which the targeted platform does
> not typically use.
>
> The last patch is for viewing where the memory allocations are going and
> is not to be applied, of course.
I am not entirely convinced we need this for the upcoming release. My
concern is that this patch set makes a lot of changes. OK, they are
mostly limited to the IEEE 1275 stuff but...
Anyway, quick glance through the patches revealed that most of them
missing explanation why they are really needed. At least... Please
fix these things...
Daniel
- [PATCH 6/8] kern/ieee1275/init: ppc64: Implement alloc_mem_restricted, (continued)
- [PATCH 6/8] kern/ieee1275/init: ppc64: Implement alloc_mem_restricted, Stefan Berger, 2023/10/27
- [PATCH 8/8] debug: Display successful memory claims, Stefan Berger, 2023/10/27
- [PATCH 7/8] loader/powerpc/ieee1275: Use new allocation function for kernel and initrd, Stefan Berger, 2023/10/27
- [PATCH 2/8] kern/ieee1275/init: ppc64: Decide by request whether to initialize region, Stefan Berger, 2023/10/27
- [PATCH 1/8] kern/ieee1275/init: ppc64: Introduce a request for regions_claim, Stefan Berger, 2023/10/27
- [PATCH 3/8] kern/ieee1275/init: ppc64: Return allocated address and len using context, Stefan Berger, 2023/10/27
- [PATCH 4/8] kern/ieee1275/init: ppc64: Check early for sufficiently large chunk, Stefan Berger, 2023/10/27
- [PATCH 5/8] kern/ieee1275/init: ppc64: Add support for alignment requirements, Stefan Berger, 2023/10/27
- Re: [PATCH 0/8] ppc64: Restrict memory allocations for kernel and initrd,
Daniel Kiper <=