grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v17 04/20] libtasn1: changes for grub compatibility


From: Daniel Kiper
Subject: Re: [PATCH v17 04/20] libtasn1: changes for grub compatibility
Date: Mon, 17 Jun 2024 17:12:12 +0200

On Fri, Jun 14, 2024 at 02:45:37PM +0800, Gary Lin wrote:
> Based on the patch from "Daniel Axtens <dja@axtens.net>"
>
> Do a few things to make libtasn1 compile as part of grub:
>
>  - remove _asn1_strcat and replace strcat with the bound-checked
>    _asn1_str_cat except the one inside _asn1_str_cat. That strcat is
>    replaced with strcpy.
>
>  - adjust header paths in libtasn1.h
>
>  - replace a 64 bit division with a call to grub_divmod64, preventing
>    creation of __udivdi3 calls on 32 bit platforms.

This patch should be split into three separate patches.

I think this and other libtasn1 fixes should have
"Signed-off-by: Daniel Axtens <dja@axtens.net>" here.

> Signed-off-by: Gary Lin <glin@suse.com>

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]