guile-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Guile-commits] 04/13: tests: Check TCP_NODELAY for non-zero instead of


From: Ludovic Courtès
Subject: [Guile-commits] 04/13: tests: Check TCP_NODELAY for non-zero instead of 1.
Date: Sun, 20 Oct 2024 15:23:21 -0400 (EDT)

civodul pushed a commit to branch main
in repository guile.

commit a8ce7f1f92c60fc191bb6d27502f149fcc68298c
Author: Tomas Volf <~@wolfsden.cz>
AuthorDate: Sat Aug 10 00:54:27 2024 +0200

    tests: Check TCP_NODELAY for non-zero instead of 1.
    
    POSIX does not explicitly say that stored value using setsockopt will be
    returned by getsockopt.  At least for TCP_NODELAY on Darwin they do
    differ.  Darwin returns internal define TF_NODELAY (4) instead of 1 the
    test expected.  Since for boolean flags "non-zero is true", rewrite the
    test to check just that.
    
    * test-suite/tests/00-socket.test ("setsockopt AF_INET")
    ["IPPROTO_TCP TCP_NODELAY"]: Check for non-zero value from getsockopt.
    
    Signed-off-by: Ludovic Courtès <ludo@gnu.org>
---
 test-suite/tests/00-socket.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test-suite/tests/00-socket.test b/test-suite/tests/00-socket.test
index b3692f61a..17e686225 100644
--- a/test-suite/tests/00-socket.test
+++ b/test-suite/tests/00-socket.test
@@ -147,7 +147,7 @@
       (pass-if "IPPROTO_TCP TCP_NODELAY"
        (let ((sock (socket AF_INET SOCK_STREAM 0)))
           (setsockopt sock IPPROTO_TCP TCP_NODELAY 1)
-          (eqv? 1 (getsockopt sock IPPROTO_TCP TCP_NODELAY))))))
+          (not (eqv? 0 (getsockopt sock IPPROTO_TCP TCP_NODELAY)))))))
 
 
 ;;;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]