[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add adwaita-icon-theme.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: Add adwaita-icon-theme. |
Date: |
Wed, 13 May 2015 09:55:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
宋文武 <address@hidden> skribis:
> Ludovic Courtès <address@hidden> writes:
>
>> 宋文武 <address@hidden> skribis:
>>
>>> * gnu/packages/gnome.scm (adwaita-icon-theme): New variable.
>>
>> [...]
>>
>>> +(define-public adwaita-icon-theme
>>> + (package (inherit gnome-icon-theme)
>>> + (name "adwaita-icon-theme")
>>> + (version "3.16.0")
>>> + (source (origin
>>> + (method url-fetch)
>>> + (uri (string-append "mirror://gnome/sources/" name "/"
>>> + (version-major+minor version) "/"
>>> + name "-" version ".tar.xz"))
>>> + (sha256
>>> + (base32
>>> + "1cbfdypxfg74krqrklh4za64jhvskbp206l14fs739cw14xsvj53"))))
>>> + (native-inputs
>>> + ;; XXX: gtk-encode-symbolic-svg lacks SVG support.
>>> + (alist-delete "gtk+" (package-native-inputs gnome-icon-theme)))))
>>
>> Why is this ‘alist-delete’ needed? Perhaps you just need to expound the
>> comment.
> With 'gtk+', it will:
> 1. use gtk-update-icon-cache to build a index-theme.cache (ok)
> 2. use gtk-encode-symbolic-svg to convert symbolic SVGs to PNGs (failed)
>
> The reason is gtk-encode-symbolic-svg lacks librsvg support for
> gdk-pixbuf, maybe we should wrap it with GDK_PIXBUF_MODULE_FILE.
Ah I see. Then what about having the comment say something like “Remove
GTK+ so that gtk-encode-symbolic-svg isn’t invoked since it is currently
broken.”?
>> Also, I think specific ‘synopsis’ and ‘description’ need to be
>> provided.
> The gnome-icon-theme was renamed to adwaita-icon-theme after 3.12,
> So, I think the 'synopsis' and 'description' applied too.
Ah OK, perfect.
Feel free to push with the amended comment.
>> WDYT?
> I plan to fix the 'gtk-encode-symbolic-svg' and remove the
> 'alist-delete'.
Even better. :-) That can come as a later commit, if you want.
Thank you!
Ludo’.
- [PATCH] gnu: Add adwaita-icon-theme., 宋文武, 2015/05/12
- Re: [PATCH] gnu: Add adwaita-icon-theme., Ludovic Courtès, 2015/05/12
- Re: [PATCH] gnu: Add adwaita-icon-theme., 宋文武, 2015/05/12
- Re: [PATCH] gnu: Add adwaita-icon-theme.,
Ludovic Courtès <=
- Re: [PATCH] gnu: Add adwaita-icon-theme., 宋文武, 2015/05/19
- Re: [PATCH] gnu: Add adwaita-icon-theme., Ludovic Courtès, 2015/05/22
- Re: [PATCH] gnu: Add adwaita-icon-theme., 宋文武, 2015/05/22
- Re: [PATCH] gnu: Add adwaita-icon-theme., Mark H Weaver, 2015/05/23
- Re: [PATCH] gnu: Add adwaita-icon-theme., Ludovic Courtès, 2015/05/23
- Re: [PATCH] gnu: Add adwaita-icon-theme., 宋文武, 2015/05/26