Re: [PATCH] gnu: Add adwaita-icon-theme.

[宋文武]

Ludovic Courtès <address@hidden> writes:

> 宋文武 <address@hidden> skribis:
>
>> From ff7e16bc8b7e803d49d5ee880f31f3f4e1660d3c Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <address@hidden>
>> Date: Tue, 19 May 2015 16:32:09 +0800
>> Subject: [PATCH 1/2] gnu: gtk+: Add SVG support to 'gtk-encode-symbolic-svg'.
>>
>> * gnu/packages/gtk.scm (gtk+)[inputs]: Add librsvg.
>>   [arguments]: Add 'wrap-gtk-encode-symbolic-svg' phase.
>
> [...]
>
>> +        'install 'wrap-gtk-encode-symbolic-svg
>> +        (lambda* (#:key inputs outputs #:allow-other-keys)
>> +          (let* ((out (assoc-ref outputs "out"))
>> +                 (prog (string-append out "/bin/gtk-encode-symbolic-svg"))
>> +                 (librsvg (assoc-ref inputs "librsvg"))
>> +                 (loaders.cache (find-files librsvg "^loaders\\.cache$")))
>> +            (wrap-program prog
>> +              `("GDK_PIXBUF_MODULE_FILE" = ,loaders.cache))))
>> +        %standard-phases))))))
>
> Could you add a comment there explaining what’s going on?
OK.
>
> So ‘gtk-encode-symbolic-svg’ uses that loader mechanism, which is why it
> doesn’t actually support SVG out-of-the-box, even if librsvg is already
> an input, right?
Yes.
>
> This would have to be committed in a gtk-rebuild branch.
Done.

Thanks for review!