[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: base: Avoid circular dependency among glibc-hurd-header
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: base: Avoid circular dependency among glibc-hurd-headers and hurd-minimal. |
Date: |
Sun, 31 May 2015 22:25:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Manolis Ragkousis <address@hidden> skribis:
> From 744e51fc7f61685fd6785a64cefbaeb3cf87d2ec Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Wed, 27 May 2015 17:22:43 +0300
> Subject: [PATCH] gnu: base: Avoid circular dependency among glibc-hurd-headers
> and hurd-minimal.
>
> There is a circular dependency between glibc-hurd-headers and hurd-minimal,
> where
> one expects the other, while only the later needs the former.
>
> * gnu/packages/base.scm (glibc/hurd-headers): Add correct propagated-inputs.
[...]
> --- a/gnu/packages/base.scm
> +++ b/gnu/packages/base.scm
> @@ -758,6 +758,8 @@ command.")
> (package (inherit glibc/hurd)
> (name "glibc-hurd-headers")
> (outputs '("out"))
> + (propagated-inputs `(("gnumach-headers" ,gnumach-headers)
> + ("hurd-headers" ,hurd-headers)))
> (arguments
> (substitute-keyword-arguments (package-arguments glibc/hurd)
> ;; We just pass the flags really needed to build the headers.
The patch makes sense to me: it’s a case of library A using headers of
libraries B and C, so B and C must be propagated.
I’m not sure why you mention a circular dependency in the message, and
what this has to do with that though. I think the message should simply
be:
gnu: glibc/hurd-headers: Propagate Hurd and Mach headers.
* gnu/packages/base.scm (glibc/hurd-headers)[propagated-inputs]: New
field.
Thanks!
Ludo’.