guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] GCJ: run libjava tests.


From: Ricardo Wurmus
Subject: Re: [PATCH] GCJ: run libjava tests.
Date: Thu, 22 Oct 2015 15:41:28 +0200

Andreas Enge <address@hidden> writes:

> On Thu, Oct 22, 2015 at 01:07:25PM +0200, Ricardo Wurmus wrote:
>>         ((#:phases phases)
>>          `(modify-phases ,phases
>> +           (replace 'check
>> +            (lambda _ (zero? (system* "make" "check-target-libjava"))))
>
> Could this be replaced by
>    #:test-target "check-target-libjava"
> ? Apart from that, your patch looks very useful.

Ah, good idea.  I’m trying to build GCJ right now by adding this

    ((#:tests? _) #t)
    ((#:test-target _) "check-target-libjava")

to the ‘substitute-keyword-arguments’ expression instead of replacing
the “check” phase.  If this works I’ll push an updated patch.

Thanks!

~~ Ricardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]