guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] GCJ: run libjava tests.


From: Ricardo Wurmus
Subject: Re: [PATCH] GCJ: run libjava tests.
Date: Tue, 27 Oct 2015 15:39:15 +0100

Ludovic Courtès <address@hidden> writes:

> Ricardo Wurmus <address@hidden> skribis:
>
>> Attached is a new patch that pulls the ‘#:test-target’ line out of the
>> ‘substitute-keyword-arguments’ expression.  The indentation of many
>> lines changes because of this.  ‘git diff -w’ shows that the actual
>> change is pretty small.
>
> [...]
>
>> +     `(#:test-target "check-target-libjava"
>> +       ,@(substitute-keyword-arguments `(#:modules ((guix build 
>> gnu-build-system)
>> +                                                    (guix build utils)
>> +                                                    (ice-9 regex)
>> +                                                    (srfi srfi-1)
>> +                                                    (srfi srfi-26))
>> +                                                   ,@(package-arguments 
>> gcc))
>
> #:test-target could even go after #:modules in the argument to
> ‘substitute-keyword-arguments’, for consistency.

Ah, yes, that’s much prettier.  I’ll push with this change.  Thanks!

~~ Ricardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]