[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] gnu: Add picocom.
From: |
Leo Famulari |
Subject: |
Re: [PATCH 1/6] gnu: Add picocom. |
Date: |
Mon, 26 Sep 2016 13:24:57 -0400 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Mon, Sep 26, 2016 at 12:34:42PM +0200, David Craven wrote:
> * gnu/packages/terminals.scm (picocom): New variable.
> + (arguments
> + `(#:make-flags '("CC=gcc")
> + #:tests? #f
Please add a comment saying that there is no test suite (that's what I
understand from skimming the GitHub web page).
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (man (string-append out "/share/man")))
This path should be "/share/man/man1".
Otherwise looks good to me!
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., (continued)
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Leo Famulari, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Ludovic Courtès, 2016/09/28
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Tobias Geerinckx-Rice, 2016/09/27
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Mark H Weaver, 2016/09/27
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., John Darrington, 2016/09/28
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Ludovic Courtès, 2016/09/28
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Ludovic Courtès, 2016/09/28
Re: [PATCH 1/6] gnu: Add picocom.,
Leo Famulari <=