[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel varian
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant. |
Date: |
Wed, 28 Sep 2016 23:15:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Mark H Weaver <address@hidden> skribis:
> Our conventions for commit logs, which follow the GNU Coding Standards
> for Change Logs (see section 6.8 of the GNU Coding Standards), is that
> explanations belong in the comments of the code itself, not in the
> commit log. If that had been done in the example you give above, you
> would have known why the line was needed in a small fraction of the time
> that it must have taken you to perform all the steps above.
>
> However, I agree that commits that _remove_ code should include the
> rationale in the commit log, if the reason is not obvious and if there's
> no sensible place to put the explanation in the code.
>
> What do you think?
+1
Ludo’.
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., (continued)
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Leo Famulari, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., John Darrington, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., David Craven, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Vincent Legoll, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., David Craven, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Leo Famulari, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Ludovic Courtès, 2016/09/28
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Tobias Geerinckx-Rice, 2016/09/27
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Mark H Weaver, 2016/09/27
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., John Darrington, 2016/09/28
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.,
Ludovic Courtès <=
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Ludovic Courtès, 2016/09/28
Re: [PATCH 1/6] gnu: Add picocom., Leo Famulari, 2016/09/26