guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] http: Support fetching builds by derivation.


From: Ludovic Courtès
Subject: Re: [PATCH] http: Support fetching builds by derivation.
Date: Tue, 01 Oct 2019 11:25:56 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello!

Christopher Baines via "Development of GNU Guix and the GNU System
distribution." <address@hidden> skribis:

> There's a one to one mapping of build id to derivation, so allow querying by
> derivation file name as well. I'm looking at this as I'm interested in getting
> build information in to the Guix Data Service.
>
> * src/cuirass/http.scm (url-handler): Add new clause to match statement, to
> return build information by derivation file name.

[...]

> +    (("build" "gnu" "store" derivation-file-name)

Perhaps we can avoid /gnu/store in the URL, and…

> +     (let* ((full-derivation-file-name
> +             (string-append "/gnu/store/" derivation-file-name))

… use (%store-prefix) instead of "/gnu/store" here

Otherwise LGTM, thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]