[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] http: Support fetching builds by derivation.
From: |
Christopher Baines |
Subject: |
Re: [PATCH] http: Support fetching builds by derivation. |
Date: |
Thu, 17 Oct 2019 21:21:56 +0100 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Christopher Baines <address@hidden> writes:
> Ludovic Courtès <address@hidden> writes:
>
>> Hello!
>>
>> Christopher Baines via "Development of GNU Guix and the GNU System
>> distribution." <address@hidden> skribis:
>>
>>> There's a one to one mapping of build id to derivation, so allow querying by
>>> derivation file name as well. I'm looking at this as I'm interested in
>>> getting
>>> build information in to the Guix Data Service.
>>>
>>> * src/cuirass/http.scm (url-handler): Add new clause to match statement, to
>>> return build information by derivation file name.
>>
>> [...]
>>
>>> + (("build" "gnu" "store" derivation-file-name)
>>
>> Perhaps we can avoid /gnu/store in the URL, and…
>>
>>> + (let* ((full-derivation-file-name
>>> + (string-append "/gnu/store/" derivation-file-name))
>>
>> … use (%store-prefix) instead of "/gnu/store" here
>
> Sure, I've sent another patch with these changes.
I've gone ahead and pushed this as
9acb0aa55b5787edef885bb812e2ee66d4401e80.
signature.asc
Description: PGP signature