Re: Adding Substitute Mirrors page to installer

[Mathieu Othacehe]

Hello,

Sorry again for the long delay.

> Of course, it feels somewhat dirty, as there is a need to read the 
> configuration file.
> It would be cleaner if a page could affect the field created by a previous 
> page.

Yes I agree. In the meantime, I think that the configuration file read
is an acceptable solution.

> I think Less is More, and deploying an installer with a simple "select one
> mirror" page *now* will cover 90% of use-cases, and we can add the more
> complicated page later when there is more time.

Seems fair.

I ran the installer tests with this command: make check-system
TESTS="gui-installed-os". The following error is reported:

--8<---------------cut here---------------start------------->8---
conversation expecting pattern ((quote list-selection) ((quote title) 
"Partitioning method") ((quote multiple-choices?) #f) ((quote items) 
(not-encrypted encrypted _ ...)))
/gnu/store/h38i2hvaqy9bd0sbn9isdfzl7m56mngr-shepherd-marionette.scm:1:1718: 
ERROR:
  1. &pattern-not-matched:
      pattern: ((quote list-selection) ((quote title) "Partitioning method") 
((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...)))
      sexp: (list-selection (title "Substitute mirror") (multiple-choices? #f) 
(items ("https://ci.guix.gnu.org (Berlin, official Guix substitute server)" 
"https://mirror.sjtu.edu.cn/guix (China, SJTU)")))
Backtrace:
           2 (primitive-load "/gnu/store/n6z0h9gxfkzrvsfcsbpd05kxxcx?")
In ice-9/eval.scm:
   191:35  1 (_ #f)
    619:8  0 (_ #(#<directory (guile-user) 7ffff3bb3f00> #<variabl?>))

ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote 
(choose-partitioning installer-socket #:encrypted? #f #:passphrase 
"thepassphrase" #:uefi-support? #f)))'.
note: keeping build directory `/tmp/guix-build-installation.drv-0'
builder for `/gnu/store/wp95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv' 
failed with exit code 1
build of /gnu/store/wp95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv failed
View build log at 
'/var/log/guix/drvs/wp/95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv.bz2'.
--8<---------------cut here---------------end--------------->8---

As explained here:
https://lists.gnu.org/archive/html/guix-patches/2021-05/msg00819.html,
you need to introduce a new "list-selection" conversation item in the
"choose-services" procedure of the (gnu installer tests) module to fix
this issue.

Thanks,

Mathieu