[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
patches for new packages proper workflow (Re: Tricking peer review)
From: |
Giovanni Biscuolo |
Subject: |
patches for new packages proper workflow (Re: Tricking peer review) |
Date: |
Wed, 20 Oct 2021 10:29:32 +0200 |
Hi,
zimoun <zimon.toutoune@gmail.com> writes:
[...]
>> All in all, it’s probably not as worrisome as it first seems. However,
>> it’s worth keeping in mind when reviewing a package.
>
> I agree with a minor comment. From my opinion, not enough patches are
> going via guix-patches and are pushed directly.
>
> For instance, the «Commit policy» section says «For patches that just
> add a new package, and a simple one, it’s OK to commit, if you’re
> confident (which means you successfully built it in a chroot setup, and
> have done a reasonable copyright and license auditing).»
>
> And from my point of view, new packages should *always* go via
> guix-patches, wait 15 days, then push if no remark. It lets the time
> for the community to chime in. And if not, it just slows down for 2
> weeks.
I agree with Simon, the policy to add new packages should be changed as
he proposes.
Thanks! Giovanni
--
Giovanni Biscuolo
Xelera IT Infrastructures
signature.asc
Description: PGP signature
Re: Tricking peer review, Giovanni Biscuolo, 2021/10/20
patches for new packages proper workflow (Re: Tricking peer review),
Giovanni Biscuolo <=
Re: Tricking peer review, Leo Famulari, 2021/10/20
Re: Tricking peer review, Christine Lemmer-Webber, 2021/10/25