[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: On commit access, patch review, and remaining healthy
From: |
Ludovic Courtès |
Subject: |
Re: On commit access, patch review, and remaining healthy |
Date: |
Fri, 03 Jun 2022 21:42:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi,
Pier-Hugues Pellerin <ph@heykimo.com> skribis:
> As a new-new Guix user, I did find the review process or the time it
> takes really long.
> Maybe I've tackle too complex updates[0], I don't know but I don't
> have a clear path how to push it.
Yeah. :-/
The long delays are mostly due to the lack of reviewers, but also, as
you point out, the more “complex” a patch series is, the more time it’ll
take before it’s reviewed (because it entails more work).
> Also, I don't want to say that one workflow is superior to the other
> but one thing that shines with theses forge
> is the automation and the simplicity to add tooling on pull request to
> reduce the burden to the reviewer:
>
> - linting
> - checks
> - commits log formatting check
> - CI jobs
> - codeowner assignment
> - build packages (partial or complete rebuild the world if needed)
> - license check
> - notification for stable pull request.
Yeah, I think there’s consensus on this. :-)
> All theses are useful quality of life improvement for reviewers and
> reduce some of the friction and remove some of the
> non glamourous-task. Maybe it could be added to Mumi? Maybe a bot like
> Ofborg in NixOS could take care of some of the operation.
Yup.
> I haven't watched Arun presentation, I will search the list if the
> recording is up somewhere.
It’s right here:
https://guix.gnu.org/en/blog/2022/online-guix-days-2022-announcement-2/
Thanks,
Ludo’.
- Re: On commit access, patch review, and remaining healthy, (continued)
- Re: On commit access, patch review, and remaining healthy, Ludovic Courtès, 2022/06/03
- Re: On commit access, patch review, and remaining healthy, Ricardo Wurmus, 2022/06/03
- Re: On commit access, patch review, and remaining healthy, Efraim Flashner, 2022/06/07
- Re: On commit access, patch review, and remaining healthy, Ludovic Courtès, 2022/06/07
- Re: On commit access, patch review, and remaining healthy, Efraim Flashner, 2022/06/08
- Re: On commit access, patch review, and remaining healthy, Ludovic Courtès, 2022/06/08
- Re: On commit access, patch review, and remaining healthy, Hartmut Goebel, 2022/06/20
- Re: On commit access, patch review, and remaining healthy, zimoun, 2022/06/21
- Re: On commit access, patch review, and remaining healthy, Munyoki Kilyungi, 2022/06/22
Re: On commit access, patch review, and remaining healthy, Pier-Hugues Pellerin, 2022/06/02
- Re: On commit access, patch review, and remaining healthy,
Ludovic Courtès <=
Re: On commit access, patch review, and remaining healthy, Luis Felipe, 2022/06/02
Re: On commit access, patch review, and remaining healthy, Arun Isaac, 2022/06/06
- Re: On commit access, patch review, and remaining healthy, Ludovic Courtès, 2022/06/06
- Re: On commit access, patch review, and remaining healthy, zimoun, 2022/06/07
- Re: On commit access, patch review, and remaining healthy, Giovanni Biscuolo, 2022/06/08
- Re: On commit access, patch review, and remaining healthy, zimoun, 2022/06/14
- Re: On commit access, patch review, and remaining healthy, Arun Isaac, 2022/06/15
- Re: On commit access, patch review, and remaining healthy, Ludovic Courtès, 2022/06/15