guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/03: guix-install.sh: Improve prompt_yes_no procedure.


From: Lars-Dominik Braun
Subject: Re: 01/03: guix-install.sh: Improve prompt_yes_no procedure.
Date: Mon, 10 Oct 2022 17:44:51 +0200

Hi Maxim,

> commit 6a2e303d3a49baf7c222a70b91f453e9efd456c6
> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> AuthorDate: Wed Oct 5 21:48:25 2022 -0400
> 
>     guix-install.sh: Improve prompt_yes_no procedure.
>     
>     * etc/guix-install.sh (_flush): New function.
>     (prompt_yes_no): Clear input, then only read the first character, 
> silently.
>     Add the [Yes/no] string to the message.  When a newline is entered by the
>     user, treat it as the default value, which is "yes".
>     (chk_gpg_keyring): Remove "(yes/no)" from the prompt message.
>     (configure_substitute_discovery): Likewise.
>     (sys_authorize_build_farms): Likewise.
I got a report here[1] that this refactoring broke my GitHub action,
which simply pipes `yes` into guix-install.sh. Thus all pipelines
depending on https://github.com/PromyLOPh/guix-install-action are (again)
broken. Shall we revert this or do you have a quick fix at hand?

Lars

[1] https://github.com/PromyLOPh/guix-install-action/issues/16



reply via email to

[Prev in Thread] Current Thread [Next in Thread]