bug#27225: [PATCH] artwork: Use a descriptive name for the source directory.

[Alex Kost]

Leo Famulari (2017-06-03 19:54 -0400) wrote:

> * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> use the full commit hash when fetching.
> ---
>  gnu/artwork.scm | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/artwork.scm b/gnu/artwork.scm
> index 94c89143a..204845bd6 100644
> --- a/gnu/artwork.scm
> +++ b/gnu/artwork.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2014, 2015 Ludovic Courtès <address@hidden>
> +;;; Copyright © 2017 Leo Famulari <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -28,13 +29,15 @@
>  ;;; Code:
>  
>  (define %artwork-repository
> -  (origin
> -    (method git-fetch)
> -    (uri (git-reference
> -          (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> -          (commit "6998d30")))
> -    (sha256
> -     (base32
> -      "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j"))))
> +  (let ((commit "6998d30425289b087c64f63e7415df2241e591db"))
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +             (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> +             (commit commit)))
> +      (file-name (string-append "guix-artwork-" (string-take commit 7) 
> "-checkout"))

As for me, this line is too long, I would make it:

       (file-name (string-append "guix-artwork-" (string-take commit 7)
                                 "-checkout"))

> +      (sha256
> +       (base32
> +        "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j")))))
>  
>  ;;; artwork.scm ends here

-- 
Alex