[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45018] [PATCH 3/6] daemon: Factorize substituter agent spawning.
From: |
Mathieu Othacehe |
Subject: |
[bug#45018] [PATCH 3/6] daemon: Factorize substituter agent spawning. |
Date: |
Fri, 04 Dec 2020 09:19:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hey Ludo,
> + const std::map<string, string> env = { { "_NIX_OPTIONS",
> settings.pack() } };
> + runningSubstituter = std::make_shared<Agent>(settings.guixProgram,
> args, env);
The only owner of this Agent is LocalStore, so why not using
make_unique? This function could return a const reference to the Agent
instead.
Thanks,
Mathieu
[bug#45018] [PATCH 0/6] Process and connection reuse for substitutions, 宋文武, 2020/12/03
[bug#45018] [PATCH 0/6] Process and connection reuse for substitutions, Ludovic Courtès, 2020/12/03