guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45018] [PATCH 3/6] daemon: Factorize substituter agent spawning.


From: Mathieu Othacehe
Subject: [bug#45018] [PATCH 3/6] daemon: Factorize substituter agent spawning.
Date: Fri, 04 Dec 2020 09:19:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hey Ludo,

> +     const std::map<string, string> env = { { "_NIX_OPTIONS", 
> settings.pack() } };
> +     runningSubstituter = std::make_shared<Agent>(settings.guixProgram, 
> args, env);

The only owner of this Agent is LocalStore, so why not using
make_unique? This function could return a const reference to the Agent
instead.

Thanks,

Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]