[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45018] [PATCH 4/6] daemon: Run 'guix substitute --substitute' as an
From: |
Ludovic Courtès |
Subject: |
[bug#45018] [PATCH 4/6] daemon: Run 'guix substitute --substitute' as an agent. |
Date: |
Sun, 06 Dec 2020 22:53:09 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi,
Mathieu Othacehe <othacehe@gnu.org> skribis:
>> + /* The substituter. */
>> + std::shared_ptr<Agent> substituter;
>
> There's only one owner at a time, right? Maybe prefer unique_ptr.
I’m not sure I understand the semantics of ‘unique_ptr’. ‘shared_ptr’
does reference counting, AIUI, and that’s what I want here, no?
Ludo’.
- [bug#45018] [PATCH 1/6] daemon: 'Agent' constructor takes a list of environment variables., (continued)
[bug#45018] [PATCH 0/6] Process and connection reuse for substitutions, 宋文武, 2020/12/03
[bug#45018] [PATCH 0/6] Process and connection reuse for substitutions, Ludovic Courtès, 2020/12/03
- [bug#45018] [PATCH 0/6] Process and connection reuse for substitutions, Mathieu Othacehe, 2020/12/04
- [bug#45018] [PATCH v2 0/6] Process and connection reuse for substitutions, Ludovic Courtès, 2020/12/06
- [bug#45018] [PATCH v2 2/6] daemon: Use 'Agent' to spawn 'guix substitute --query'., Ludovic Courtès, 2020/12/06
- [bug#45018] [PATCH v2 6/6] daemon: Raise an error if substituter doesn't send the expected hash., Ludovic Courtès, 2020/12/06
- [bug#45018] [PATCH v2 1/6] daemon: 'Agent' constructor takes a list of environment variables., Ludovic Courtès, 2020/12/06
- [bug#45018] [PATCH v2 3/6] daemon: Factorize substituter agent spawning., Ludovic Courtès, 2020/12/06
- [bug#45018] [PATCH v2 5/6] substitute: Cache and reuse connections while substituting., Ludovic Courtès, 2020/12/06
- [bug#45018] [PATCH v2 4/6] daemon: Run 'guix substitute --substitute' as an agent., Ludovic Courtès, 2020/12/06