[bug#46703] [PATCH] gnu: add bmake

[Nicolas Goaziou]

Hello,

qblade via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/build-tools.scm (bmake): New variable.

Thank you. Some comments follow.

> +    (name "bmake")
> +    (version "20200902")

There is a newer version available. Could you provide it instead?

I tried to quickly update it (hash
"07n9avzdg6gifrzyddnyzada5s5rzklvbqfpv5drljpxcgpqpvwg") but there are
additional failing tests.

> +    (arguments
> +     `(#:tests? #f ;; test in build

You need a single semicolon for end-of-line comments. Also (nitpick),
I find ";test during build" clearer.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'configure 'fix-test ;; fix from nixpkgs

See above for comment syntax.

> +    (description "Program designed to simplify the maintenance of
> +other programs.")

I suggest:

    "bmake is a program designed to simplify the maintenance of other
    programs.  Its input is a list of specifications as to the files upon which
    programs and other files depend."

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou