guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47182] [PATCH 07/18] gnu: binutils-final: Support more Power archit


From: Efraim Flashner
Subject: [bug#47182] [PATCH 07/18] gnu: binutils-final: Support more Power architectures.
Date: Tue, 16 Mar 2021 09:49:29 +0200

On Mon, Mar 15, 2021 at 11:45:00PM -0700, Chris Marusich wrote:
> * gnu/packages/commencement.scm (binutils-final)[arguments]: When checking if
> the system is a Power architecture, instead of hard-coding "powerpc-linux",
> use the target-powerpc? procedure so it works on more Power architectures.
> [inputs]: Likewise.
> ---
>  gnu/packages/commencement.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
> index c0732bbf62d..d4511ed9148 100644
> --- a/gnu/packages/commencement.scm
> +++ b/gnu/packages/commencement.scm
> @@ -3516,14 +3516,14 @@ exec ~a/bin/~a-~a -B~a/lib -Wl,-dynamic-linker 
> -Wl,~a/~a \"$@\"~%"
>         #:implicit-inputs? #f
>         #:allowed-references
>         ,@(match (%current-system)
> -         ("powerpc-linux"
> +         ((? target-powerpc?)

I wonder if this would be better as ,@(if target-powerpc?
I didn't test to see how it would work with cross compiling, I don't
know if binutils-final gets built in that case.

>            `(("out" ,glibc-final ,static-bash-for-glibc)))
>           (_
>            `(("out" ,glibc-final))))
>         ,@(package-arguments binutils)))
>      (inputs
>       (match (%current-system)
> -       ("powerpc-linux"
> +       ((? target-powerpc?)
>          `(("bash" ,static-bash-for-glibc)
>            ,@(%boot2-inputs)))
>         (_ (%boot2-inputs))))))
> -- 
> 2.26.2
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]